Marian Zeis Profile picture
Jul 4 8 tweets 5 min read
How can a reviewer get a quick overview of a pull request?
One possibility is to provide the pull request directly in a test environment.
For our open source project #bestofui5 on GitHub we provide the pull requests ad hoc directly as an #Azure Static Web App.
How? 👇 Image
In general, we use the possibilities of GitHub Actions, Azure Static Web Apps and Azure CLI here. Especially because these can be used free of charge.
The app is an #OpenUI5 app.
github.com/ui5-community/…
The data comes from another GitHub repository.
github.com/ui5-community/…
It does not make sense to provide this for all PRs.
So that the user can easily trigger the deployment, we have created a label for this.
When the label is added to a PR, an Azure Static Web App is created, a build is performed and this build is deployed.
github.com/ui5-community/… Image
It´s also possible to let the GitHub Action 'Azure/static-web-apps-deploy' build the app, in this case we do it before hand manually.
In this action, the app is identified by the api token.
After the successful build, the action will comment a public link to the app in the PR. Image
Now when the PR is updated, a new build is also automatically triggered.
github.com/ui5-community/…
If the PR is now closed or merged, the static app is then also automatically deleted.
github.com/ui5-community/… Image
Thus, it is much easier for contributors and reviewers to check the changes.
You can see a test PR here:
github.com/ui5-community/…
The documentation for that is here:
github.com/ui5-community/…
I see @lechnerc77 is always interested in that kind of stuff :)
The big advantage of this setup:
Since we generate a new static app each time and have no further dependencies towards Azure, we can deploy more Pre-production environments than provided in the free plan.
Only three environments are provided per app
docs.microsoft.com/en-us/azure/st…

• • •

Missing some Tweet in this thread? You can try to force a refresh
 

Keep Current with Marian Zeis

Marian Zeis Profile picture

Stay in touch and get notified when new unrolls are available from this author!

Read all threads

This Thread may be Removed Anytime!

PDF

Twitter may remove this content at anytime! Save it as PDF for later use!

Try unrolling a thread yourself!

how to unroll video
  1. Follow @ThreadReaderApp to mention us!

  2. From a Twitter thread mention us with a keyword "unroll"
@threadreaderapp unroll

Practice here first or read more on our help page!

More from @mianbsp

Jun 16
1/ I'm on my way to self-employment and since I don't have any projects yet, I'm dedicating my time to open source projects on GitHub.
I am primarily working in the SAP ecosystem.
github.com/marianfoo
Here are all the projects I have been working on lately:
2/ @exercism_io is an open source and free code learning platform.
@LarsHvam has created a tremendous solution to compile ABAP to JS.
This made it possible to add #ABAP to #Exercism.
I have added two new exercises here that can be solved by you:
exercism.org/tracks/abap
3/ "Best of UI5" is the new entry page that shows the best community projects in the UI5 Ecosystem.
As a little pet project of my own, together with @pmuessig . I improve it all the time.
Currently new packages have been added:
bestofui5.org/#/packages?sor…
github.com/ui5-community/…
Read 10 tweets

Did Thread Reader help you today?

Support us! We are indie developers!


This site is made by just two indie developers on a laptop doing marketing, support and development! Read more about the story.

Become a Premium Member ($3/month or $30/year) and get exclusive features!

Become Premium

Don't want to be a Premium member but still want to support us?

Make a small donation by buying us coffee ($5) or help with server cost ($10)

Donate via Paypal

Or Donate anonymously using crypto!

Ethereum

0xfe58350B80634f60Fa6Dc149a72b4DFbc17D341E copy

Bitcoin

3ATGMxNzCUFzxpMCHL5sWSt4DVtS8UqXpi copy

Thank you for your support!

Follow Us on Twitter!

:(