I've finished comparing the released Ashigaru code with @SamouraiWallet.
I did this for my own, personal usage, but it might serve others. Feel free to add your remarks/questions, DYOR and/or wait for more reviews.
TL;DR: I found nothing wrong and plan to use it soon.
I did this for my own, personal usage, but it might serve others. Feel free to add your remarks/questions, DYOR and/or wait for more reviews.
TL;DR: I found nothing wrong and plan to use it soon.
I ran a diff between this release and TDevD's commit from Apr 24th. I didn't check the code between the latest SW release and that date since I already trusted SW.
Ashigaru devs (AD) published release notes [1] and there are also the commit messages from SW commit radar [2].
Ashigaru devs (AD) published release notes [1] and there are also the commit messages from SW commit radar [2].
SW had a fork of bitcoinj. I never had it cloned and it's possible the repository is lost :(
The library and source code are downloaded from JitPack. According to their logs [3], it was built in Mar 20th.
Unless AD are wicked and in cahoots with JitPack, it should be safe to me.
The library and source code are downloaded from JitPack. According to their logs [3], it was built in Mar 20th.
Unless AD are wicked and in cahoots with JitPack, it should be safe to me.
From ExtLibJ, which is used for Stonewall, Soroban, BIP47 etc, there are no changes, except for backend URLs.
Comparison was made with @noosphere888x2 repository [4].
Ok, so now on to the actual review.
Comparison was made with @noosphere888x2 repository [4].
Ok, so now on to the actual review.
New features: the wallet pings an onion URL to see if there's a new version, maybe because there's no Play store and they have no social media.
Also there's a new wallet sync view.
Tor and own Dojo are now mandatory.
Also there's a new wallet sync view.
Tor and own Dojo are now mandatory.
OXT explorer was removed. Apparently one is available only if the Dojo instance has one.
Soroban (without Joinbot) and Ricochet are back. So is PayNym, under a new directory. The connect fee has been waived.
Whirlpool removed from the GUI and also options to call SW's support.
Soroban (without Joinbot) and Ricochet are back. So is PayNym, under a new directory. The connect fee has been waived.
Whirlpool removed from the GUI and also options to call SW's support.
About the new directory, I would like to file a complaint against the CEO. What the hell was that 😭😭😭🗣️🗣️🗣️
To finish the review, there were many changes due to rebranding, changing URLs, colours and addresses.
To finish the review, there were many changes due to rebranding, changing URLs, colours and addresses.
The build is reproducible as per the instructions. I used unzip instead of apktool because it's faster and was already installed.
That's it, congratulations and good luck to Ashigaru devs. Now, take some time to visit [5].
#FreeSamourai
Links:
[1]
[2]
[3]
[4]
[5] freesamourai.com
ashigaru.rs/news/release-w…
t.me/SamouraiCommit…
jitpack.io/io/samourai/co…
github.com/noosphere888/E…
freesamourai.com
#FreeSamourai
Links:
[1]
[2]
[3]
[4]
[5] freesamourai.com
ashigaru.rs/news/release-w…
t.me/SamouraiCommit…
jitpack.io/io/samourai/co…
github.com/noosphere888/E…
freesamourai.com
• • •
Missing some Tweet in this thread? You can try to
force a refresh
