Thread by @embeddedgus

Linus is happy when people fix old bad code.😃 #OSSummit

git.kernel.org/pub/scm/linux/… 🐧

In this thread I'll start documenting all the years-old bugs I find and fix across the whole kernel tree.

https://twitter.com/embeddedgus/status/1126114240065089536

Bugfix for a 10-year-old bug in arch sh:

git.kernel.org/pub/scm/linux/… 🐧

This bug was introduced in November 2009.

Bugfix for an 8-year-old bug in USB:

git.kernel.org/pub/scm/linux/… 🐧

This bug was introduced in June 2011.

Bugfix for a 7-year-old bug in Radeon DRM:

git.kernel.org/pub/scm/linux/… 🐧

This bug was introduced in January 2012.

Bugfix for a 2-year-old bug in AMD DRM:

git.kernel.org/pub/scm/linux/… 🐧

This bug was introduced in April 2017.

Bugfix for a 7-year-old bug in perf test code:

git.kernel.org/pub/scm/linux/… 🐧

This bug was introduced in September 2012.

Bugfix for a 7-year-old bug in USB:

Bad bit shift operation:
git.kernel.org/pub/scm/linux/… 🐧

The bugfix has just landed in multiple stable trees:
lwn.net/Articles/80338… 😃

This bug was introduced in April 2012.

Bugfix for a 12-year old bad-logic bug in MTD:

lore.kernel.org/linux-mtd/3fb0… 🐧

This bug was introduced in December 2008.

10-year old logically dead code in WLAN:

lore.kernel.org/lkml/202005052… 🐧

This code was introduced in March 2010. This issue was found thanks to the ongoing efforts to remove zero-length and one-element arrays from the kernel.

A 3 and a half years old out-of-bounds bug in CIFS:

lore.kernel.org/linux-hardenin… 🐧

It's been applied and will soon appear in stable:
git.samba.org/?p=sfrench/cif…

This bug was introduced in September 2017, and it was found thanks to the ongoing efforts to globally enable -Warray-bounds.

This bugfix has now been applied to 4 different -stable trees: Linux 5.10.15, 5.4.97, 4.19.175 and 4.14.221. 🐧😀

lwn.net/Articles/84556…