When I was a jr engineer at AWS my PR’s went through 100+ comments and 7+ revisions due to poor code quality. The friendly, helpful feedback helped me improve.
Now as a mid-level I tend to ship code in <= 2 revisions with minimal comments.
Here’s how I’m doing it. 🧵👇
1️⃣ I understand why code quality matters.
We read code 10x more than we write it. Our code must be understandable so our team can maintain and add features.
Poorly written code causes PR churn, which results in delayed delivery and can block other team members.
👇
2️⃣ I take on small tasks.
A good PR starts before any code is written. The task should be small, resulting in an easily reviewable PR.
Bad task: UpdateWidget API
Better: split into 4 separate tasks - UpdateWidget model; AuthN/AuthZ; input validation; implementation