Thread by @eSquareDesign

reinteractive delivers a comprehensive App Review for Ruby on Rails. Needless to say over the years we have found some incredible things here are my top 5 good and bad (all real examples for production apps!) (a thread)

The Good!

1/An overwhelming majority of apps we review score greater than 80 on Ruby Critic test
2/a 90% test code coverage (yet to see the fabled 100%)
3/A readme so through that a new dev is able to spin up the local environment including complex dependencies measured in minutes
4/“We’ll just finish off the 7.x upgrade before you start your review”
5/"We just wanted an independent opinion on how our developers are going" (bonus points when those developers are present in your report delivery meeting and they engage like a group pairing session)

The Bad!
1/The App that had just one line in the readme file: “todo: fill this in”
2/“We don’t own the github repo - you’ll need to talk to our developer about that”
3/Production database credentials in plain text in the code
4/“We just use the production database for testing”
5/Rails 2.x

And any time the developer has difficulty in getting the gitX login details over to you. They are either (i) not using git at all, (ii) trying to hide something in there (iii)madly fixing something (or all of the above), or at best just not on top of things

I’ve learnt to take nothing for granted. Even with the most egregious problems Rails apps can keep running, and sometimes even the best written apps can do with a little love and re-factoring.

You can get a review done on your app - it’s not very expensive, and there is no obligation for further engagement or purchases after delivery
reinteractive.com/articles/ruby-…