The original software geek. Langr Software Solutions; PubMob. 5 books + contributor to Clean Code, Clean Agile. Bringing delight to software development.
Jan 28, 2022 • 9 tweets • 3 min read
PRs: The worst possible way to review code (1/7)
We used to talk when reviewing code. Now we throw a pointer to a diff over a wall, and trust that others care enough to do a good review. (Or cynically, hope they don't care enough to find things we must fix.)
No one really wants to spend time on PRs, and as such most of us minimize such efforts. We find surface-level problems and move on. The resulting rubber-stamp process creates false confidence and pointless delay.
Feb 27, 2020 • 17 tweets • 2 min read
The Dikstra quote I tweeted about "not introducing bugs" elicited a few responses, some predictable and some not, that highlight a severe problem that pervades in our industry. // 1
Predictable: "Programs were a lot smaller back then." So what? Many things are a lot simpler *today* than they were then (e.g. we don't have to build our own sort routines). // 2
