Profile picture
, 10 tweets, 3 min read Read on Twitter
Do you want your code reviewed by me and @silveira_bells on a live stream?
On Monday 14:00 GMT (Twitch Event: twitch.tv/events/4n7KOY7…) me and Isa Silveira will be doing a live stream where we are going to talk about how to do code review, and we figure it would be so cool if the code we review came from you, the viewers.
How to submit your code

1. If it’s not your own code, make sure that you have approval from managers that we show the code (we’ll give a shoutout to your company as thanks).
Alternatively, rewrite the code to protect the innocent - it doesn’t have to be a real project per se (but it might be hard for us to understand if we don’t get access to the code)
2. Add us (github.com/mpj and github.com/bella-silveira 3) to your project with an access level that allows us to make comments on PRs.
3. Make a pull request with a change.
4. Post the link to the PR here or privately email to fff-code-review@mpj.me. Also include instructions on what we can show on screen and which parts of the project we should hide from the live stream.
Also any build instructions, setups instructions are really helpful if it’s not in the readme - context about the project also great.
5. Bonus (but not necessary) is if the code is publicly readable so that viewers can check it out during stream. This is REALLY NOT critical - we much prefer to show real imperfect company code that we can only show parts of, not pretty showoff open sourced code.
And of course, we promise to be lovely to your code, this is no Hell’s Kitchen and you don’t need to be afraid. 💛
Missing some Tweet in this thread?
You can try to force a refresh.

Like this thread? Get email updates or save it to PDF!

Subscribe to mpj 💛
Profile picture

Get real-time email alerts when new unrolls are available from this author!

This content may be removed anytime!

Twitter may remove this content at anytime, convert it as a PDF, save and print for later use!

Try unrolling a thread yourself!

how to unroll video

1) Follow Thread Reader App on Twitter so you can easily mention us!

2) Go to a Twitter thread (series of Tweets by the same owner) and mention us with a keyword "unroll" @threadreaderapp unroll

You can practice here first or read more on our help page!

Follow Us on Twitter!

Did Thread Reader help you today?

Support us! We are indie developers!


This site is made by just three indie developers on a laptop doing marketing, support and development! Read more about the story.

Become a Premium Member ($3.00/month or $30.00/year) and get exclusive features!

Become Premium

Too expensive? Make a small donation by buying us coffee ($5) or help with server cost ($10)

Donate via Paypal Become our Patreon

Thank you for your support!