Profile picture
Andrew Clark @acdlite
, 5 tweets, 2 min read Read on Twitter
When reviewing a PR, it’s essential that you leave a comment. Any comment. Even the PR looks great and you have no substantial feedback, find something trivial to nitpick or question. This communicates intelligence and mastery, and is widely appreciated by your colleagues.
Automated code quality tools like @PrettierCode and @geteslint can sometimes make this difficult, but with a little creativity, no PR is immune to your scrutiny.
Above all else, it’s so important to *have an opinion* about everything. Even the smallest things. Don’t let lack of knowledge or context or experience keep you from sharing your wisdom. And when you’re done sharing your wisdom with your teammates, tweet.
Indeed! Pedantry is the truest marker of genius. cc: @neiltyson
Nit: “dysfunctional” is the more common spelling
Missing some Tweet in this thread?
You can try to force a refresh.

Like this thread? Get email updates or save it to PDF!

Subscribe to Andrew Clark
Profile picture

Get real-time email alerts when new unrolls are available from this author!

This content may be removed anytime!

Twitter may remove this content at anytime, convert it as a PDF, save and print for later use!

Try unrolling a thread yourself!

how to unroll video

1) Follow Thread Reader App on Twitter so you can easily mention us!

2) Go to a Twitter thread (series of Tweets by the same owner) and mention us with a keyword "unroll" @threadreaderapp unroll

You can practice here first or read more on our help page!

More from @acdlite see all

Profile picture
I've been trying to write about Concurrent React, but I'm finding it difficult because everything is so interconnected.

So I'm starting from scratch with a new approach: write all the topics down, flesh out the details, then break and edit the result into managable pieces.
These are really rough outlines, mostly notes for myself so I don't forget later.

I'm finding it hard to query my brain for all the interesting things. If there's something you'd like to know about Concurrent React or Suspense (or React in general), let me know!
And then maybe that will motivate me to stop yak shaving and write the damn docs already. Get it together, Drewfus!
Read 6 tweets
Profile picture
How to Code Split with React Suspense

Coming soon to open source.

We're already shipping a version of this to Facebook employees. The code is sooo much nicer than before.
Fun fact: the same API works in sync mode, too. The difference is that we have to fallback to the spinner immediately, as if `delayMs={0}`. But you still get the nicer programming model.
Another fun fact: zero component state is required to make this work. No lifecycle methods either. None. Nada. Not even as an implementation detail.
Read 4 tweets
Profile picture
Part of React's philosophy is to provide escape hatches, for when the idiomatic patterns break down. This is great! But... when it comes to the core parts of your architecture (shared components and frameworks), you should try to avoid cheating as much as possible.
It's not just that these anti-patterns may lead to bugs. It's that they suggest deeper architectural flaws that could create bigger problems in the future.

The React team's job is to identify why people resort to cheating, and provide them with a more idiomatic solution.
Hence: React Suspense, getDerivedStateFromProps, the new context API

All our best features arise from things that used to require cheating. Next time you're tempted to cheat, reach out to us! We may already have a better solution for you. If we don't... let's build it!
Read 3 tweets

Related threads

Profile picture
@VictoriaLIVE @ProfRWinston @Aisleyne1 @BBCTwo @BBCNews Let's look at A's reasons for voting #Leave:
"Us being able to fix our our problems. I think the #NHS, our teachers are underpaid, and I believe that we put so much money into the EU."
a) We CAN fix our own problems. Public services are 100% managed by own Govt —

/1.
@VictoriaLIVE @ProfRWinston @Aisleyne1 @BBCTwo @BBCNews — except the bits Govt privatised! The EU does not interfere with how our Govt runs the NHS or its education policy or the police force, etc.

The competences of the EU are defined by treaty. They tend to be issues that extend beyond national borders.

/2.
@VictoriaLIVE @ProfRWinston @Aisleyne1 @BBCTwo @BBCNews Typical areas include trade, environment & security.

Think about it. When was the last time you heard the #NHS complaining to the EU abt underfunding? Or schools complaining the the EU abt kids going hungry? Never. They complain to our Govt cos' OUR GOVT is responsible.

/3.
Read 11 tweets
Profile picture
Peter Thiel’s final advice (summary) on @rubinreport:

I was super tracked. In high school I knew I was gonna go to Stanford, and then Stanford law, and I ended up at a top tier law firm in Manhattan.
It was one of those places from the outside, everyone wanted to get in, and from the inside, everyone wanted to get out.

I was in a quarter life crisis in my mid 20s. Why did I end up in this, what did I do?
I just followed the track and I wasn’t thinking about why I was doing things or what I was doing.

The tracks are not working anymore.

I think they worked better in the past, they stopped working for gen x, and they work even less for millennials.
Read 7 tweets
Profile picture
The Ku Klux Klan has embarked on a recruitment campaign in upstate New York in recent months, dropping off packets of white supremacist propaganda and sweetening the material with bars of Snickers in an initiative seemingly aimed at young people. 1) baltimore.cbslocal.com/2018/08/04/aft…
New York Gov. Andrew Cuomo on Friday ordered state police to investigate and directed the state police Hate Crimes Task Force to kick off a “public awareness campaign” to counter hate. 2)
“While President Trump and Republicans in Washington sow divisiveness and hate that is spreading like a cancer across the country, in New York we say not here, not now, not ever,” Cuomo said in a news release.

“New York has zero tolerance for intolerance.” 3)
Read 6 tweets
Profile picture
Something I've found to be vital over the years is style congruency.

Here's a thread with my take on it-

There needs to be a synergy between the attitude you exude and the clothes you wear.

It's hard to be taken seriously as a G if you're out wearing cargo shorts and crocs.
Obviously, depending on the area you're in, it doesn't always make sense to wear a suit out every night.

However, the clothes you wear are important.

If you lift and are in great shape, why limit yourself with poor fitting clothing?

It's key to maximize all visible traits.
For myself, if I'm not wearing a suit, I'll go with-

Dress boots
Dark, slim jeans
Fitted vneck or henley
Leather jacket (if weather permits)

This is my outfit 90% of the time that I'm not wearing a suit.

Why? Because my ratio of wearing this and getting laid is the highest
Read 21 tweets
Profile picture
I have a small file of scientific facts that make me go “wow”. And today, a friend started a thread asking for everyone’s favourite scientific facts, concepts, postulates and questions.

Here are a few of my favourites. #thread
1. The reason ten feels like a round number is totally random: a function of the evolution of ten fingers on our hands. Every number base is base 10.

math.stackexchange.com/questions/1668…
2. We are made up of the same basic matter that makes up the rest of the universe. Some of this matter organised itself and developed “intelligence”. And eyes. We are a way for the universe to look at itself.

livescience.com/32828-humans-r…
Read 20 tweets
Profile picture
IMPORTANT UPDATES ABOUT PUERTO RICO: Hundreds of nurses are pouring in to help and they are reporting terrible conditions across the largely destroyed island. Is urgent that we SHARE this THREAD to raise awareness of what’s still happening. Please don’t forget about #PuertoRico
Nurses are reporting “still not water or electricity in Rio Grande, Puerto Rico since Maria.” Nurses have set up a clinic at a FEMA site and I’m quoting here “This was also FEMA’s first day there,” this is a report of today folks! Nearly 3weeks after hurricane!
I can't stress this enough folks! This nurses are leaving their children & families, taking their vacation time to go help our brothers & sisters in #PuertoRico they'll have no water, no electricity & no roof over their heads for weeks! This is a true humanitarian crisis.
Read 24 tweets

Trending hashtags

#WeNeedGFA #appeal #BRAVE #Limerick #Somerset #Luton #Trump #AccidentsWillHappen #EU #Gloucester #bregretters #Ireland #Dishonored #finalsayforall #Liverpool #Mayo #Blaydon #ThereIsNoBrexitDividend #PuertoRicoReliefNOW #Warrington #StopBrexitSaveBritain #Devonport #ItsTime #Sutton #Who

Did Thread Reader help you today?

Support us! We are indie developers!

This site is made by just three indie developers on a laptop doing marketing, support and development! Read more about the story.

Become a Premium Member and get exclusive features!

Premium member ($3.00/month or $30.00/year)

Too expensive? Make a small donation by buying us coffee ($5) or help with server cost ($10)

Donate via Paypal Become our Patreon

Thank you for your support!