,
15 tweets,
2 min read
Read on Twitter
Only 7% of emotional communication comes from the content of what you say. The rest comes from how you say it, and your facial expressions while you're saying it
Review the code, not the author
Ask questions rather than issuing commands
Provide links and documentation to back up your comments
Avoid scope creep - only review the changes submitted
Document any conversations held outside of the ticketing system
Use inclusive language - "we" instead of "you"
Review the ticket as a whole, not just the code changes
Make it clear which comments are suggestions vs requirements
Everyone's opinion is valid, no matter experience or seniority
Show appreciation for good practice or code
Assign appropriate reviewer(s) based on relevant knowledge / experience
Do not be toxic, and call out toxicity in others
Don't be lazy - take the time to review large changes in detail. If possible, break down large changes into smaller units
